On Nov 11, 2019, at 1:10 PM, Lassi Kortela lassi@lassi.io wrote:
Indeed, resisting the temptation to push commits directly to master is a winning move for multi-contributor repos :)
GitHub PRs correspond 1:1 to Git branches, so if you do all your work in topic branches, it's almost effortless to make a PR for each branch. The branches can come from the main repo or any fork: equally easy.
As a bonus, all popular CI services automatically run CI for each PR, so if you go via PR you're merging only tested code to master.
IIRC GitHub has some branch protection system so you can block direct commits to master. The switch is somewhere in the repo's settings.
Yes I see all the advantages now. But bad habits are hard to get rid of… I still haven’t found a painless way to do the github pull-requests from the command-line.
Could you guys share the steps that work for you? Do you use “hub”?
Marc