Hi,
Does strings.js need to be included by default in 'make test'? My current stdlib implementation is done (the test-on-top-of-v8 part, not the tachyon-with-iir part), but committing it would break the master branch. I get a bus error after tachyon attempts to compile it:
Parsing Tachyon source: "stdlib/strings.js" Generating IR for: "stdlib/strings.js" Performing IR lowering for: "stdlib/strings.js" Generating machine code for: "stdlib/strings.js" Linking machine code for: "stdlib/strings.js" Initializing standard library make: *** [test] Bus error
Any suggestions?
Bruno
Afficher les réponses par date
Hmm, I had that error but then fixed it. Can you try doing a git pull, see if it happens on the latest commit?
Or do you mean make test worked until you added your code to strings.js? If so, I guess we'll need to debug that. Probably your code does something on initialization (when strings.js is run) that our current code doesn't handle properly. Perhaps you can commit it in another branch and I can look at it with Erick tomorrow, figure out what causes the error.
- Maxime
Hi,
Does strings.js need to be included by default in 'make test'? My current stdlib implementation is done (the test-on-top-of-v8 part, not the tachyon-with-iir part), but committing it would break the master branch. I get a bus error after tachyon attempts to compile it:
Parsing Tachyon source: "stdlib/strings.js" Generating IR for: "stdlib/strings.js" Performing IR lowering for: "stdlib/strings.js" Generating machine code for: "stdlib/strings.js" Linking machine code for: "stdlib/strings.js" Initializing standard library make: *** [test] Bus error
Any suggestions?
Bruno_______________________________________________ Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list
On 2011-02-03, at 19:29 , chevalma@iro.umontreal.ca wrote:
Hmm, I had that error but then fixed it. Can you try doing a git pull, see if it happens on the latest commit?
I was working before I added my code to the file.
Or do you mean make test worked until you added your code to strings.js? If so, I guess we'll need to debug that. Probably your code does something on initialization (when strings.js is run) that our current code doesn't handle properly. Perhaps you can commit it in another branch and I can look at it with Erick tomorrow, figure out what causes the error.
The error is due to executing the tests at the end of the file, so I just commented them out for now and committed in the master branch. I was just surprised that strings.js gets pulled in while arrays.js doesn't.
Bruno
- Maxime
Hi,
Does strings.js need to be included by default in 'make test'? My current stdlib implementation is done (the test-on-top-of-v8 part, not the tachyon-with-iir part), but committing it would break the master branch. I get a bus error after tachyon attempts to compile it:
Parsing Tachyon source: "stdlib/strings.js" Generating IR for: "stdlib/strings.js" Performing IR lowering for: "stdlib/strings.js" Generating machine code for: "stdlib/strings.js" Linking machine code for: "stdlib/strings.js" Initializing standard library make: *** [test] Bus error
Any suggestions?
Bruno
The error is due to executing the tests at the end of the file, so I just commented them out for now and committed in the master branch. I was just surprised that strings.js gets pulled in while arrays.js doesn't.
I just wanted to try integrating the strings code now to see how this approach works out. When the array code is ready, we'll add it too.
Should I go ahead and try refactoring your code to make it work with the primitives, do you want to come to the lab tomorrow afternoon or Monday so we can test this out together?
- Maxime
On 2011-02-03, at 21:21 , chevalma@iro.umontreal.ca wrote:
The error is due to executing the tests at the end of the file, so I just commented them out for now and committed in the master branch. I was just surprised that strings.js gets pulled in while arrays.js doesn't.
I just wanted to try integrating the strings code now to see how this approach works out. When the array code is ready, we'll add it too.
Should I go ahead and try refactoring your code to make it work with the primitives, do you want to come to the lab tomorrow afternoon or Monday so we can test this out together?
I can stop by if you think it'll help, otherwise, feel free to change the code as much as you want.
Bruno
Ok, well my demo ends at 12:30, I should be available after 1 PM. If you have some time perhaps you can pass by and give me a short overview of your implementation... And perhaps we can try testing some of its basic features in the shell :)
- Maxime
On 2011-02-03, at 21:21 , chevalma@iro.umontreal.ca wrote:
The error is due to executing the tests at the end of the file, so I just commented them out for now and committed in the master branch. I was just surprised that strings.js gets pulled in while arrays.js doesn't.
I just wanted to try integrating the strings code now to see how this approach works out. When the array code is ready, we'll add it too.
Should I go ahead and try refactoring your code to make it work with the primitives, do you want to come to the lab tomorrow afternoon or Monday so we can test this out together?
I can stop by if you think it'll help, otherwise, feel free to change the code as much as you want.
Bruno_______________________________________________ Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list
On 2011-02-03, at 21:43 , chevalma@iro.umontreal.ca wrote:
Ok, well my demo ends at 12:30, I should be available after 1 PM. If you have some time perhaps you can pass by and give me a short overview of your implementation... And perhaps we can try testing some of its basic features in the shell :)
I'm rather busy today, and I can't really leave my office because there's a submission for my class later today. So, how about we do this the other way around: I'll be in my office most of the day, so just come see me if there's anything I can do to help you.
Bruno
Allrighty.
- Maxime
On 2011-02-03, at 21:43 , chevalma@iro.umontreal.ca wrote:
Ok, well my demo ends at 12:30, I should be available after 1 PM. If you have some time perhaps you can pass by and give me a short overview of your implementation... And perhaps we can try testing some of its basic features in the shell :)
I'm rather busy today, and I can't really leave my office because there's a submission for my class later today. So, how about we do this the other way around: I'll be in my office most of the day, so just come see me if there's anything I can do to help you.
Bruno_______________________________________________ Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list
Bruno, are you ready to push your code on master?
- Maxime
Allrighty.
- Maxime
On 2011-02-03, at 21:43 , chevalma@iro.umontreal.ca wrote:
Ok, well my demo ends at 12:30, I should be available after 1 PM. If you have some time perhaps you can pass by and give me a short overview of your implementation... And perhaps we can try testing some of its basic features in the shell :)
I'm rather busy today, and I can't really leave my office because there's a submission for my class later today. So, how about we do this the other way around: I'll be in my office most of the day, so just come see me if there's anything I can do to help you.
Bruno_______________________________________________ Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list
Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list
But it isn't there :'(
Perhaps you forgot to push, or pushed into a branch.
- Maxikme
On 2011-02-04, at 12:46 , chevalma@iro.umontreal.ca wrote:
Bruno, are you ready to push your code on master?
I did that yesterday...
Bruno _______________________________________________ Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list