You forgot to do a "git add" on utility/constants.js, so I removed it from the makefile. I also moved the definition of MAX_FIXNUM to runtime/objects.js, and calculate it dynamically using Math.pow. Committed on the repository.
- Maxime
On 10-12-18 03:39 PM, Maxime Chevalier-Boisvert wrote:
I replaced Infinity by MAX_FIXNUM as suggested by Marc in
Hmm, I think you only used infinity for interval bounds. Do you think you could define your own MAX_INTERVAL instead, or use false/undefined, or simply your own infinity constant just for register allocation (defined to be 2^20 or something). I don't really like the idea of having a constant that depends on our tagging scheme in utility.
I think we should generally avoid defining a "MAX_FIXNUM", but if we do define one, it should be defined under primitives/objects, along with our other tagging scheme constants.
- Maxime
Tachyon-list mailing list Tachyon-list@iro.umontreal.ca https://webmail.iro.umontreal.ca/mailman/listinfo/tachyon-list