[gambit-list] Proposed patch

Marc Feeley feeley at iro.umontreal.ca
Mon Dec 16 13:09:54 EST 2013

On Dec 16, 2013, at 12:50 PM, Bradley Lucier <lucier at math.purdue.edu> wrote:

> Marc:
> I've added tests of the exceptions that should be raised for several of the trigonometric and hyperbolic functions, exp, log, and sqrt, and a few more.

Great.  I'll take a look soon.

> I see now that if I want to add files to the git repository, then "git diff" will not be enough to show which files are added.  I guess if I want to do more, I'll need to learn a bit of git.

After you create a unit test, you need to "git add" it.  I.e.

   git add tests/unit-tests/03-number/mynewtest.scm

You can check if you have forgotten to "git add" files by doing a

   git status

You'll see which files were modified, which were added, and which are untracked (that you might consider "git add"ing).

Then, you should do a

   git add -p

to review your changes to the modified files (you can individually accept/reject each patch hunk with y/n, or all in a file with a).

Then you should do a

   make commit

To commit your changes and give a description.

Then you can do a

   make push

to push your commit to the Gambit repo.

That's all there is to it!

> Here is a file containing the unit-tests directory after my changes.
> Brad
> <unit-tests.tgz>


More information about the Gambit-list mailing list