[gambit-list] Proposed patch

Bradley Lucier lucier at math.purdue.edu
Tue Dec 10 16:10:23 EST 2013

On 12/10/2013 12:10 PM, Marc Feeley wrote:
> On Dec 10, 2013, at 11:45 AM, Bradley Lucier <lucier at math.purdue.edu> wrote:
>> Thanks for the comments.
>> On 12/10/2013 09:38 AM, Marc Feeley wrote:
>> What is missing for this patch is a bunch of unit tests.  Each of the new inlined primitives should be tested for precision (after all, that is why they were added, so unit tests should verify this).
>> Later.  I promise. :-)
> Not good enough!  If I don't take a hard line on this one, things will slip.  But I can help you!
> >From now on, patches for new functionality will have to come with appropriate unit tests.  Unit tests for existing features will have to be added too.

Oh great and powerful Oz, I bring you the broom of the Wicked Witch of 
the East ... No, no, that can't be right, let's see ...

I offer you 63 unit tests (including all branch cuts and special values) 
in supplication that you might accept my good patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: trigtests.scm
Type: text/x-scheme
Size: 3515 bytes
Desc: not available
URL: <http://mailman.iro.umontreal.ca/pipermail/gambit-list/attachments/20131210/a712a8fc/attachment.bin>

More information about the Gambit-list mailing list