I began the work to separate out the Tachyon C primitives from the code for the D8 extensions/proxies. As such, I created two new files, d8/tachyon-exts.cc and d8/tachyon-exts.h. I also created a d8-tachyon-exts.h header file, to be included in <V8>/src/d8.cc instead of including the cc file directly. I updated the instructions on how to modify V8 to make this work in d8-tachyon-exts.cc. This is now committed on the repository. Two minor issues: 1. I didn't have the profiler source, so I commented out the contents of the profiling functions for now. 2. I also created a loader.cc file for the image loader code, which will rely on our C primitives as well. I'm thinking of renaming our source/d8 folder to something like source/csrc, or something to reflect that it's a folder containing our C primitives, and not just d8 related code. Opinions? - Maxime
Afficher les réponses par date
On 2011-04-06, at 5:53 PM, chevalma@iro.umontreal.ca wrote:
I began the work to separate out the Tachyon C primitives from the code for the D8 extensions/proxies.
As such, I created two new files, d8/tachyon-exts.cc and d8/tachyon-exts.h. I also created a d8-tachyon-exts.h header file, to be included in <V8>/src/d8.cc instead of including the cc file directly.
I updated the instructions on how to modify V8 to make this work in d8-tachyon-exts.cc. This is now committed on the repository.
Good.
Two minor issues:
1. I didn't have the profiler source, so I commented out the contents of the profiling functions for now.
OK.
2. I also created a loader.cc file for the image loader code, which will rely on our C primitives as well. I'm thinking of renaming our source/d8 folder to something like source/csrc, or something to reflect that it's a folder containing our C primitives, and not just d8 related code. Opinions?
Alternative names which sound better than csrc: - source/host - source/os - source/support I vote for "host". Marc
On 2011-04-06, at 7:05 PM, Marc Feeley wrote:
Two minor issues:
1. I didn't have the profiler source, so I commented out the contents of the profiling functions for now.
OK.
I have to delete the current files anyway.
2. I also created a loader.cc file for the image loader code, which will rely on our C primitives as well. I'm thinking of renaming our source/d8 folder to something like source/csrc, or something to reflect that it's a folder containing our C primitives, and not just d8 related code. Opinions?
Alternative names which sound better than csrc:
- source/host - source/os - source/support
I vote for "host".
Why not organize by functionality? I vote for exts/ and loader/, or something similar. Bruno
participants (3)
-
Bruno Dufour -
chevalma@iro.umontreal.ca -
Marc Feeley